Pbckp 137 vs move pg node #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a910a2 to
d01804b
Compare
d01804b to
8be1b3a
Compare
avaness
reviewed
Apr 27, 2023
testgres/node.py
Outdated
| "-w" if wait else '-W', # --wait or --no-wait | ||
| "start" | ||
| ] + params # yapf: disable | ||
| get_bin_path("pg_ctl"), |
There was a problem hiding this comment.
remove excessive tabs/spaces to not override history
There was a problem hiding this comment.
It doesn't change git history. I don't know why it is showing like this, but no changes here from my side.
There was a problem hiding this comment.
I fixed tabs according flake8 requirements, I hope it will be ok now
|
LGFM, please don't forget squash commits to essential ones (or reorder and squash them) before merge |
avaness
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.